Update and reduction #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illusional
requested changes
Jun 3, 2024
There was a problem hiding this comment.
I think you've copied a lot from production-pipelines, which has a different from what we'd recommend. I'd want to keep markdownlint, and I'm not 100% confident on removing black, I think I'd like to discuss that more before we move forward with that.
If you can clean-up production-pipeline carryover (removed markdown lint, some large_file exclude, lots of changes in pyproject.toml), and keep black - happy to re-review.
|
@MattWellie, otherwise I'm more likely conservitely update #15, merge that and then leave this as a suggestion to discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for some feedback here - this repo was out of date relative to ones with decent activity. This is an update/upgrade(?)
Specifically I'm not sure on the interaction between COM812 and
split-on-trailing-comma = false- do we want to split all lists with trailing commas even if they'll fit on one line (for more meaningful git diffs in future), or condense lists that will fit on a single line for overall file size/line count?supersedes #15? (sorry, hadn't seen that)